search

KyberNetwork / smart-contracts

Main smart contracts for Kyber Network, including the main platform contract, reserve contracts etc.
https://kyber.network
MIT License
378 stars 340 forks source link

Deduplication PR for emptyHintFix PR #1018

Closed ayobuenavista closed 4 years ago

ayobuenavista commented 4 years ago

Made a PR to emptyHintFix PR based on discussion with Desmond. He suggested since splits != 0, is checked twice, might as well remove the check in the first one. So the SplitsNotEmptyError checks for BestOfAll, MaskIn, MaskOut now (previously just MaskIn, MaskOut).

Can just close this if it's not needed, as the previous PR is already valid and working as well.

Anyhowclick commented 4 years ago

Ilan said it's too late, so... gonna close it