KyberNetwork / smart-contracts

Main smart contracts for Kyber Network, including the main platform contract, reserve contracts etc.
https://kyber.network
MIT License
378 stars 340 forks source link

getExpectedRateAfterFee with empty hint returns an exception #1096

Open Samboy76 opened 1 year ago

Samboy76 commented 1 year ago

Hello, when passing in an empty converted bytes array or empty string value in javascript into getExpectedRateAfterFee

const expectedRate = await kyber.functions.getExpectedRateAfterFee(
                                          srcToken.address,
                                          destToken.address, 
                                          querySrcAmount,
                                          bps,
                                          "" // empty hints

  );

or equally attempted to do the same from within solidity contract:

uint expectedRate = kyber.getExpectedRateAfterFee(ERC20(srcTokenAddress), ERC20(destTokenAddress), querySrcAmount, bps, bytes(""));

both of which returns the below same error message:

_Failure message: call revert exception [ See: https://links.ethers.org/v5-errors-CALL_EXCEPTION ](method="getExpectedRateAfterFee(address,address,uint256,uint256)", data="0x", errorArgs=null, errorName=null, errorSignature=null, reason=null, code=CALLEXCEPTION, version=abi/5.7.0)

Any ideas please?