search

KyberNetwork / smart-contracts

Main smart contracts for Kyber Network, including the main platform contract, reserve contracts etc.
https://kyber.network
MIT License
378 stars 340 forks source link

move gas helper call to end of trade flow #830

Closed ilanDoron closed 4 years ago

ilanDoron commented 4 years ago

gas helper call at end of flow has 2 advantages.

  1. amounts are updated (after max dest amount calc).
  2. burning gas tokens cost gas . the gas payback is only after all Tx is done. if not enough gas left to burn tokens, we should avoid burn since it can cause revert.