Closed ductm54 closed 4 years ago
But these tests are still important.
Seems they test we handle this edge case correctly correctly Don't follow why it should be removed.
On Mon, May 11, 2020 at 9:13 PM ductm54 notifications@github.com wrote:
@ductm54 commented on this pull request. In test/sol6/kyberNetwork.js https://github.com/KyberNetwork/smart-contracts/pull/943#discussion_r423226916 : @@ -2074,53 +2073,6 @@ contract('KyberNetwork', function(accounts) { }); }); describe("test handle change edge case", async function(){ no need to mock to test when required is delete — You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/KyberNetwork/smart-contracts/pull/943#discussion_r423226916, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACNXTBIE237VBUTBYBNJKO3RRA53ZANCNFSM4M6EAS7Q .
In test/sol6/kyberNetwork.js https://github.com/KyberNetwork/smart-contracts/pull/943#discussion_r423226916 :
@@ -2074,53 +2073,6 @@ contract('KyberNetwork', function(accounts) { }); });
no need to mock to test when required is delete
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/KyberNetwork/smart-contracts/pull/943#discussion_r423226916, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACNXTBIE237VBUTBYBNJKO3RRA53ZANCNFSM4M6EAS7Q .
But these tests are still important.
Seems they test we handle this edge case correctly correctly Don't follow why it should be removed.
On Mon, May 11, 2020 at 9:13 PM ductm54 notifications@github.com wrote: