issues
search
KyberNetwork
/
smart-contracts
Main smart contracts for Kyber Network, including the main platform contract, reserve contracts etc.
https://kyber.network
MIT License
378
stars
340
forks
source link
set reentrancy block when call trade during claim platformFee and rebate
#980
Closed
ducquangkstn
closed
4 years ago
ducquangkstn
commented
4 years ago
Case:
The platform has the fee of 5 wei
call
claimPlatformFee
-> receive 4 wei
trigger callback function -> Earn some more platform fees
PlatformFeePaid emitted. -> platform fee is not reset to 1
In this PR:
add reentrancy guard to claimPlatformFee, handleFees, claimReserveRebate
add claimPlatformFee to IKyberFeeHandler
Case:
In this PR: