search

KybernetikGames / animancer

Documentation for the Animancer Unity Plugin.
66 stars 8 forks source link

Mixer Transitions show a toggle on their child speeds when they shouldn't #258

Closed KybernetikGames closed 2 months ago

KybernetikGames commented 1 year ago

Environment

Description

These toggles below the Speed header shouldn't be there.

upload_2023-2-10_18-21-25

Reproduction

  1. Make a mixer transition field.
  2. Add some animations to it.
  3. Change one of their speeds.
  4. Make sure your Inspector is wide enough to not have the toggles off the side of the screen.

Fix

  1. Open ManualMixerTransitionAsset.cs.
  2. Go to the _Speeds field (not _Speed).
  3. Mark the [AnimationSpeed] attribute just above it as optional:
#if UNITY_EDITOR
[AnimationSpeed(IsOptional = false)]
#endif
chemicalcrux commented 1 year ago

A little gotcha -- IsOptional doesn't exist at build-time, so I had to wrap the attribute in an #if UNITY_EDITOR to make my builds work!

KybernetikGames commented 1 year ago

Thanks for letting me know, I've edited the OP.

KybernetikGames commented 3 months ago

Animancer v8.0 is now available for Alpha Testing and includes this fix..

KybernetikGames commented 2 months ago

Animancer v8.0 is now fully released.