search

Kyjor / JulGame.jl

JulGame is a game engine based on the Julia programming language with the help of SDL2.
https://docs.kyjor.io/JulGame.jl
The Unlicense
94 stars 3 forks source link

Vector structures refactorization #36

Closed achengli closed 6 months ago

achengli commented 6 months ago

Hello @Kyjor

I refactored Vector structs from Math module. The principal modification is the reduction of complexity from having Vectorf (Float) and Vector (Integer) to only one abstract model that constructs the others.

Kyjor commented 6 months ago

Hi @achengli , this is awesome! Thank you! Looks like there is one test failure. I'm not sure that you need to add those usings and include to the test file. FYI I'll be heading to bed soon, so I can get it reviewed and merged probably tomorrow.

achengli commented 6 months ago

Perfect @Kyjor , I removed those usings and includes from the test file, I did it during some non-rigorous tests over the structures.

Rest well!