Kyjor / JulGame.jl

JulGame is a game engine based on the Julia programming language with the help of SDL2.
https://docs.kyjor.io/JulGame.jl
The Unlicense
94 stars 3 forks source link

Refactor/deanonymize-get-prop-funcs #57

Closed mrufsvold closed 5 months ago

mrufsvold commented 5 months ago

I don't want to break the api, so I created a simple get_property function that looks up the correct function and then returns an anonymous function with "this" inserted in the first position.

I commented out a warning log about deprecation because basically every function call in the code base hits that warning at the moment. But once everything is moved to using direct function calls, we can turn on the warning to track down the last of them.

To be clear: I didn't change any logic here. Just renamed functions to snake_case and moved them out of get_property

mrufsvold commented 5 months ago

Pushed a doc string and kicked all the tests off again accidentally. Either way, ready for review!

Kyjor commented 5 months ago

This is awesome, thank you! Give me an hour or two and I can fully review it and run some manual tests that aren't covered (yet) by automation