Kylart / KawAnime

Desktop app for anime fans
MIT License
671 stars 50 forks source link

Missing Subtitles in Streaming mode #54

Closed masterian00 closed 5 years ago

masterian00 commented 5 years ago

I understand that the streaming service is still relatively new and would like to thank you for all the work you've put into the application so far. However, I have occasionally noticed the subtitles being mistimed or straight up missing on during streaming. The downloaded version has subtitles on the other hand. Also the sub fangroup in question is horriblesubs 1080p.

Kylart commented 5 years ago

I have occasionally noticed the subtitles being mistimed

The subtitles may have a little delay (we are speaking of less than 50ms here) because it's impossible to time them at a frame accuracy which is usually the case.

or straight up missing on during streaming.

Yes, that is something I've seen too. It's really hard to reproduce but usually it happens when rewinding the video when streaming. I don't know why this occurs though.. I'll have to investigate or change the way things work atm.

Thanks for pointing this out, I'll be on it!

Kylart commented 5 years ago

Alright so this is fixed on the current remake branch, soon to be merged into master