search

Kylart / MalScraper

Scrape everything you can from MyAnimeList.net
MIT License
175 stars 50 forks source link

Replace Request #101

Closed Damien111 closed 1 year ago

Damien111 commented 1 year ago

Request has been deprecated since 2020 and has recently been marked with a moderate security vulnerability as seen here.

I see only the Official API section of the package uses request, so I'm assuming it can be replaced with axios or some alternative?

@Kylart sorry to mention you but I feel this is a relatively important issue as it shows several warnings on install.

Aeden-B commented 1 year ago

In addition, the api url seems to have changed : https://myanimelist.net/clubs.php?cid=13727 Is the "Official API Constructor" part of mal-scraper still functional ? (I do not use it)

Kylart commented 1 year ago

Hey,

The official API constructor has actually been actually obsolete for a while now but tbf the whole package needs a rework and update but I don't have that much time on my hands right now. I'll be sure to set it up to date and standards whenever possible!

pendragons-code commented 1 year ago

The entire thing is made worse when parts of the api are nowhere done and the whole thing is not actually done officially with a huge backing. The lack of docs and details are a huge pain, but i guess everybody dies together here.

Kylart commented 1 year ago

Should be fixed by #113