Kylart / MalScraper

Scrape everything you can from MyAnimeList.net
MIT License
177 stars 50 forks source link

Added Support for Manga to getInfoFromName() and getResultsFromSearch() #102

Closed Damien111 closed 1 year ago

Damien111 commented 1 year ago

Tested both & working minus one small issue: When you do a query for a manga, for some reason ranked returns with the ranking + part of the code description. The bold in the example below is being added, I can take a look at this later but I don't know where to start as it uses the same function as anime searching to fetch the information.

Example: "#3592 2 based on the top manga page. Please note that 'R18+' titles are excluded"

Also went through and edited MangaDataModel's typings to contain the information actually given & keep it up to date with AnimeDataModel.

I did notice theres some overlap between AnimeDataModel & MangaDataModel, is there a desire to keep manga information in the AnimeDataModel? If not I can remove the overlap, if so I can merge MangaDataModel into AnimeDataModel & revert MangaDataModel to what it was before.

I'm assuming this won't mess with anything else as it will still default to anime searching.

I only needed these two so I haven't added support to anything else but if a change like this is wanted I can work on adding manga support to everything else that needs it.

This should also close #69

Kylart commented 1 year ago

Hey, I'm not really available to test this right now as I'm not home for a few weeks still but I'll check this out as soon as I'm back!

Thanks!

Kylart commented 1 year ago

Hey, sorry it took me so long. Thanks for the contribution!

I'll deploy that with the next release!