search

Kylart / MalScraper

Scrape everything you can from MyAnimeList.net
MIT License
177 stars 49 forks source link

[FEATURE] Adding the scraping of the reviews sections for an anime #40

Closed JustalK closed 4 years ago

JustalK commented 4 years ago

Hello,

I added the reviews scraping following the same structure of the episodes scraping. Since the number of comments is not a finished number, I added two parameter for creating a pagination system in case. limit : Allow you to limit the result to a certain number of reviews skip : Allow you to skip a number of review It was what i needed the most for one of my personal tool.

I added the tests to the implementation made (95% cov). I also added the documentation and commented my code in the hard section. I also edited a bit the package.json for fixing this => https://github.com/Kylart/MalScraper/issues/36#issue-681196131

Voila ;)

PS: I saw the modifications of the pull request but it has not move for quite a while (~6 months), the developer is not active anymore and I needed it now.

JustalK commented 4 years ago

If any question or additional thing to do, ask me ;)

Kylart commented 4 years ago

Thanks for the PR, this will be deployed soon with tag 2.8.0!