Before starting the refactoring, I will increase the coverage of the tests.
I have started with the file info.js
I have increased the coverage to 100%
I have also increase the precision of the tests
I have fixed the two bugs present in this issue : #50
I also noticed that they change the page of the seasons a bit :
https://myanimelist.net/anime/season/2017/fall
I fixed the title for having the tests to pass. But I will pass through the season.js file in the next coming days
Btw, I added nock as a dev dependencies. It's for mocking some url, particularly this one :
https://myanimelist.net/search/prefix.json?type=anime&keyword=
You have a checker that test if the result is empty but whatever I try, I dont manage to create that scenario (I try everything like %20, #, space...). So I created it. it faster and it will be usefull for testing certain case.
Hello,
Before starting the refactoring, I will increase the coverage of the tests. I have started with the file
info.jsI have increased the coverage to
100%I have also increase the precision of the tests I have fixed the two bugs present in this issue : #50I also noticed that they change the page of the seasons a bit : https://myanimelist.net/anime/season/2017/fall I fixed the title for having the tests to pass. But I will pass through the
season.jsfile in the next coming daysBtw, I added
nockas a dev dependencies. It's for mocking some url, particularly this one : https://myanimelist.net/search/prefix.json?type=anime&keyword= You have a checker that test if the result is empty but whatever I try, I dont manage to create that scenario (I try everything like %20, #, space...). So I created it. it faster and it will be usefull for testing certain case.