search

Kyle-Falconer / Court-Scheduler

3 stars 2 forks source link

Output has trouble handling multiple conferences #15

Closed chuck44 closed 10 years ago

chuck44 commented 10 years ago

When running an input with multiple conferences (bigBook.xlsx), the scheduler crashes when trying to write the resultant output file. It says there is already a sheet of this name. Run bigBook.xlsx to recreate the error.

pkmccroskey commented 10 years ago

I have tested this. The problem is that the Multiple Conference Processing story has not implemented yet (see Kanbanery #1176198). Michael and I discussed the form the output would take; the list of solutions will need to be supplied ordered by conference (then I think it was desired to be by date/time?). The output crashes when it moves on to a new conference sheet, but then a match from a previous conference is given. Side Problem: teams from different conferences are being matched together!

pkmccroskey commented 10 years ago

I will write in code to catch the exception if a bug ever produces output out of order, just in case, to prevent the program from crashing in that eventuality. Once I've done that, I'll close this Issue.

Kyle-Falconer commented 10 years ago

Are not the conference details stored within a team or match? We could write a method for CourtSchedule which returns a list of conference matches (each match grouped by conference). That way, we can write out one big master schedule, and also easily write out just a particular conference.

I don't think that writing an exception to deal with a design issue is the way to solve this.

pkmccroskey commented 10 years ago

Kyle, what you are suggesting is exactly the plan Michael was talking about, as I understand it. I was only going to write an exception as a "just in case" to catch anything if somehow that part ends up with a bug in it later. If that isn't a good idea though, I don't have to.

pkmccroskey commented 10 years ago

I have tested the multiple conference in #1176198. I guess the only thing holding this up from being closed is if I am going to (or should) add that exception to catch if conferences are out of order in the solution list.

Kyle-Falconer commented 10 years ago

I suppose that catching the exception and writing out to the console a comprehensible message about what's going on is more useful than just having it crash and burn.

On the other side, once we get this resolved, I don't see a situation where this would come up again.

pkmccroskey commented 10 years ago

Ok, we'll just call this good then and close it without unnecessary code being added.