Kyle-Falconer / Court-Scheduler

3 stars 2 forks source link

Primary/secondary days are broken #29

Closed stardustspeedway closed 10 years ago

stardustspeedway commented 10 years ago

Are these supposed to be based on grade or conference? Right now, it looks like we've got some horrendously broken mix of the two.

Kyle-Falconer commented 10 years ago

I wouldn't be surprised. I think this is supposed to be broken down on the larger (grade?)

In the config.ini, we have: conference=1-T:WUS

This indicates that (grade?) has tuesday as primary, wednesday, sunday, and saturday as secondary.

stardustspeedway commented 10 years ago

Found it, CourtScheduleIO line 427. The GUI has "JV" and "V" grades, though, and his input has neither of those AND a "JH" grade... I'll just fix the config by hand.

stardustspeedway commented 10 years ago

...Wait, there can be teams with different grades in the same conference. I'm defaulting to conference; that may result in a ton more work to do on the GUI (adding arbitrary numbers of data on conferences), but if there's a better way, I don't see it.

Kyle-Falconer commented 10 years ago

What exactly needs to change in the configuration utility then? I'm reworking it, so now's the time to tell me.

stardustspeedway commented 10 years ago

Essentially, instead of the primary/secondary day screen having a fixed number of grades, it needs to be like the holiday screen and support as many conferences as he needs. (It makes no sense to base primary/secondary days on grades when there can be multiple grades in a conference...)

That might be a little much work to get done by Thursday, but we can always have him manually write the config as a stopgap measure if necessary.

stardustspeedway commented 10 years ago

For reference: this is what the conference block should look like now. The "1a"/"2c" is a conference designation, NOT a grade.

conference=1a-R:WSU
conference=1b-R:WSU
conference=1c-F:WSU
conference=2a-F:WSU
conference=2b-WS:U
conference=2c-WS:U
stardustspeedway commented 10 years ago

As of ed1a7443ec885639c3dda1c49a3753a59d1f984e, it looks like the code is fixed.

Do we want to: A. send this off to him and have him tell us what the primary/secondary days are for each conference, then build a config manually or B. wait until the config program is done and send it all at once?

Kyle-Falconer commented 10 years ago

Are we certain that this is the right behavior? I was under the impression that grades would share conference days.

stardustspeedway commented 10 years ago

Actually, I think you're right and I was off-base. If grades is okay, then we can keep the primary/secondary window, we just need to either include a JH grade or have him use V/JV instead.

Kyle-Falconer commented 10 years ago

I don't know which, but I think JV/V is 9 and 10 on the grade scale?

stardustspeedway commented 10 years ago

JV being Junior Varsity, I'd presume that's 9-- it doesn't matter, as long as it matches what's in the spreadsheet for grade. It's all stored as strings anyway.

stardustspeedway commented 10 years ago

I think a significant portion of the weirdness of the output was that the first day was always entirely open. I tacked a band-aid over that, and now everything looks much more reasonable-- plus, now it warns you if something likely went wrong.

If there's something I missed, let me know. I'm running it one more time with production data to make sure it wasn't a fluke.

On Tue, Dec 10, 2013 at 5:47 PM, Kyle Falconer notifications@github.comwrote:

I don't know which, but I think JV/V is 9 and 10 on the grade scale?

— Reply to this email directly or view it on GitHubhttps://github.com/netinept/Court-Scheduler/issues/29#issuecomment-30280799 .

stardustspeedway commented 10 years ago

Oh, right. JH needs to either be added to the config or replaced in the xlsx with something that IS in the config-- it doesn't matter which, but if that doesn't happen it's just going to schedule the JH games on any day.

On Tue, Dec 10, 2013 at 6:31 PM, Matthew Swinney sonicsatellite@gmail.comwrote:

I think a significant portion of the weirdness of the output was that the first day was always entirely open. I tacked a band-aid over that, and now everything looks much more reasonable-- plus, now it warns you if something likely went wrong.

If there's something I missed, let me know. I'm running it one more time with production data to make sure it wasn't a fluke.

On Tue, Dec 10, 2013 at 5:47 PM, Kyle Falconer notifications@github.comwrote:

I don't know which, but I think JV/V is 9 and 10 on the grade scale?

— Reply to this email directly or view it on GitHubhttps://github.com/netinept/Court-Scheduler/issues/29#issuecomment-30280799 .

stardustspeedway commented 10 years ago

Do you want to package it, or should I do it when I get back? Either way, I'd like to have something sitting in his inbox for tomorrow if possible.

On Tue, Dec 10, 2013 at 6:35 PM, Matthew Swinney sonicsatellite@gmail.comwrote:

Oh, right. JH needs to either be added to the config or replaced in the xlsx with something that IS in the config-- it doesn't matter which, but if that doesn't happen it's just going to schedule the JH games on any day.

On Tue, Dec 10, 2013 at 6:31 PM, Matthew Swinney <sonicsatellite@gmail.com

wrote:

I think a significant portion of the weirdness of the output was that the first day was always entirely open. I tacked a band-aid over that, and now everything looks much more reasonable-- plus, now it warns you if something likely went wrong.

If there's something I missed, let me know. I'm running it one more time with production data to make sure it wasn't a fluke.

On Tue, Dec 10, 2013 at 5:47 PM, Kyle Falconer notifications@github.comwrote:

I don't know which, but I think JV/V is 9 and 10 on the grade scale?

— Reply to this email directly or view it on GitHubhttps://github.com/netinept/Court-Scheduler/issues/29#issuecomment-30280799 .

Kyle-Falconer commented 10 years ago

I'm still trying to test on Windows XP, stuck on updating it (virtual machine)

Kyle-Falconer commented 10 years ago

If you want to test this one out and then email the link to him, go ahead. My changes still aren't complete though, and this is using the old version of the configuration utility.

stardustspeedway commented 10 years ago

All right. Pushed a couple tiny little tweaks-- package when you're done with your changes.