search

KyleAMathews / docker-nginx

Nginx Docker image for easy hosting of static sites
MIT License
336 stars 108 forks source link

Use alpine #19

Closed pierreozoux closed 7 years ago

pierreozoux commented 7 years ago

I don't know if it is such a bad idea to remove the version. I think it will not break anytime soon, what is your opinion on that?

KyleAMathews commented 7 years ago

How about you just publish a different version and then add a link to it from here?

On Wed, Apr 5, 2017, 12:04 PM Pierre Ozoux notifications@github.com wrote:

I don't know if it is such a bad idea to remove the version. I think it will not break anytime soon, what is your opinion on that?

You can view, comment on, or merge this pull request online at:

https://github.com/KyleAMathews/docker-nginx/pull/19 Commit Summary

  • Use alpine

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/KyleAMathews/docker-nginx/pull/19, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEVh7JvrWSe5Ua5MMygo8f0fQC45SMYks5rs7uTgaJpZM4M0d0W .

pierreozoux commented 7 years ago

I just think it is more efficient to collaborate..

Maybe you don't like alpine at all?

I'd prefer not to have to maintain a fork, if possible.

On 05-04-2017 18:31, Kyle Mathews wrote:

How about you just publish a different version and then add a link to it from here?

On Wed, Apr 5, 2017, 12:04 PM Pierre Ozoux notifications@github.com wrote:

I don't know if it is such a bad idea to remove the version. I think it will not break anytime soon, what is your opinion on that?

You can view, comment on, or merge this pull request online at:

https://github.com/KyleAMathews/docker-nginx/pull/19 Commit Summary

  • Use alpine

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/KyleAMathews/docker-nginx/pull/19, or mute the thread

https://github.com/notifications/unsubscribe-auth/AAEVh7JvrWSe5Ua5MMygo8f0fQC45SMYks5rs7uTgaJpZM4M0d0W .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/KyleAMathews/docker-nginx/pull/19#issuecomment-291936721, or mute the thread https://github.com/notifications/unsubscribe-auth/ABxvHQ-frjChE-xZqtyiBSFiWDrgl8byks5rs8_8gaJpZM4M0d0W.

-- I use PGP to protect our privacy, if you want to know more, you can follow this https://emailselfdefense.fsf.org/en/

If you have further questions, please do not hesitate to ask. You can verify my public key here: https://keybase.io/pierreozoux

KyleAMathews commented 7 years ago

No I don't want to change to Alpine

On Wed, Apr 5, 2017, 1:33 PM Pierre Ozoux notifications@github.com wrote:

I just think it is more efficient to collaborate..

Maybe you don't like alpine at all?

I'd prefer not to have to maintain a fork, if possible.

On 05-04-2017 18:31, Kyle Mathews wrote:

How about you just publish a different version and then add a link to it from here?

On Wed, Apr 5, 2017, 12:04 PM Pierre Ozoux notifications@github.com wrote:

I don't know if it is such a bad idea to remove the version. I think it will not break anytime soon, what is your opinion on that?

You can view, comment on, or merge this pull request online at:

https://github.com/KyleAMathews/docker-nginx/pull/19 Commit Summary

  • Use alpine

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/KyleAMathews/docker-nginx/pull/19, or mute the thread

< https://github.com/notifications/unsubscribe-auth/AAEVh7JvrWSe5Ua5MMygo8f0fQC45SMYks5rs7uTgaJpZM4M0d0W

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/KyleAMathews/docker-nginx/pull/19#issuecomment-291936721 , or mute the thread < https://github.com/notifications/unsubscribe-auth/ABxvHQ-frjChE-xZqtyiBSFiWDrgl8byks5rs8_8gaJpZM4M0d0W .

-- I use PGP to protect our privacy, if you want to know more, you can follow this https://emailselfdefense.fsf.org/en/

If you have further questions, please do not hesitate to ask. You can verify my public key here: https://keybase.io/pierreozoux

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/KyleAMathews/docker-nginx/pull/19#issuecomment-291937371, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEVh0KfFwkxP9arxDJOwddGLGYx7Khgks5rs9CEgaJpZM4M0d0W .