search

KyleAMathews / element-resize-event

Library to make it easy to listen for element resize events
http://kyleamathews.github.io/element-resize-event/
MIT License
175 stars 44 forks source link

Unbind undef on exports #14

Closed karleberts closed 7 years ago

karleberts commented 7 years ago

So I evidently didn't notice that 'exports' was being redefined at the bottom of the file when 'window' existed. oops

Moving the unbind definition to after that point makes it be properly exported.

karleberts commented 7 years ago

For #12

KyleAMathews commented 7 years ago

Looks great! Could you resolve the merge conflict? I'll then merge and make a new release.

plgregoire commented 7 years ago

Hi, I just tested the modified code and it works. Unbind is now accessible and I'm able to import the lib using ES6 syntax.

However, Using Chrome Developer Tools - Profiles ,I noticed a memory leak when you attach then detach a listener.

karleberts commented 7 years ago

thanks @plgregoire, I think this should be ok now?

plgregoire commented 7 years ago

Indeed it is ! Thank you

plgregoire commented 7 years ago

Hi @KyleAMathews,

When can we expect a release ?

Thanks

dapids commented 7 years ago

Hi @KyleAMathews, any news on this?

KyleAMathews commented 7 years ago

Published 2.0.8 — thanks for everyone's help!