search

KyleAMathews / element-resize-event

Library to make it easy to listen for element resize events
http://kyleamathews.github.io/element-resize-event/
MIT License
175 stars 44 forks source link

ADD improved example + add 'resize obj' to callback #3

Closed serapath closed 9 years ago

serapath commented 9 years ago

Please see the example. If you resize the blue box, there will be a ficker, so maybe using something like "element queries" needs some good conventions in order to avoid problems.

I'm fairly new to this "element query" thing and added a @ROADMAP.md with some information about other projects i found. Do you know those?

KyleAMathews commented 9 years ago

Hey @serapath thanks for the PR but I can't think I can accept it as is. A more complete example would be a great change and I would merge that.

On your other changes—the information/question in your ROADMAP.md would be better if in issues or as changes to the README.md. To your change to return the width/height of the element—I don't want this module to measure the width/height of the element itself as I'd rather leave that up to consumers as those calls are expensive and might not be needed in every situation.

serapath commented 9 years ago

ok i understand that. Thanks for taking time.