search

KyleAMathews / modularscale

Calculate a modular scale
MIT License
9 stars 1 forks source link

Wrong label for aug 4th / dim 5th #2

Closed VinSpee closed 7 years ago

VinSpee commented 7 years ago

Hi! I love and cherish this module. Today I was implementing a design using the Augmented Fourth / Diminished Fifth (Devil's Interval) and noticed that it's mislabeled in this module as "diminished fourth).

It should be augmented fourth or diminished fifth for the Math.sqrt(2) ratio.

KyleAMathews commented 7 years ago

So it should! Fixed in https://github.com/KyleAMathews/modularscale/blob/master/src/index.coffee

KyleAMathews commented 7 years ago

BTW, curious if you've tried typography.js yet? It's this module on steroids basically :-)

KyleAMathews commented 7 years ago

Pushed a 2.0 with this change as it's a breaking change.

VinSpee commented 7 years ago

Thanks for the fix! I have looked into / am considering typography.js - I just have to tie it in to my atomic css lib / component https://github.com/VinSpee/react-shed - I'll give it a go this week. Thanks!

KyleAMathews commented 7 years ago

Oh cool! Lemme know if you have any questions! Would love to help make this happen :-)

On Mon, Feb 27, 2017 at 11:46 AM Vince Speelman notifications@github.com wrote:

Thanks for the fix! I have looked into / am considering typography.js - I just have to tie it in to my atomic css lib / component https://github.com/VinSpee/react-shed - I'll give it a go this week. Thanks!

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/KyleAMathews/modularscale/issues/2#issuecomment-282828525, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEVh51dClVoD30iBHRc63CMf6zV11RKks5rgyZugaJpZM4MMLuV .