Open vladshcherbin opened 7 years ago
What's your usecase?
@KyleAMathews we are using classes for styling and have a convention to name them as .headroom-unfixed
.
@KyleAMathews
What's your usecase?
As a general rule libraries (React or otherwise) shouldn't enforce global CSS names because:
webpack
, if both the user and myself were to attempt to use react-headroom
our styles would conflict.The last point essentially makes this library incompatible with common theming engines found in libraries like material-ui, and is the issue I ran into.
I would appreciate it if you could review and ideally merge https://github.com/KyleAMathews/react-headroom/pull/124
Please see react-autosuggest: https://github.com/moroshko/react-autosuggest#theme-prop
I'm using CSS Modules, which means that I currently have to put all headroom CSS styles in a global stylesheet, which I don't want. By being able to configure class names, I can keep the style definitions in my CSS module files.
Currently the classes are hardcoded, it would be great if we could change them.