added sk- prefix to css class names

KyleAMathews / react-spinkit

A collection of loading indicators animated with CSS for React

http://kyleamathews.github.io/react-spinkit/

MIT License

1.49k stars 73 forks source link

added sk- prefix to css class names #26

Closed ghost closed 7 years ago

ghost commented 8 years ago

@KyleAMathews

KyleAMathews commented 7 years ago

@carlos-stored somehow I missed this! This looks like a smart idea. It'd be a breaking change but namespacing CSS is unfortunately fairly necessary.

If you're still interested in the PR, feel free to fix it up and I'll make a release.

kkozee commented 7 years ago

@KyleAMathews I've never made an open source contribution but my team could use this PR for a production app that uses another generic .circle class. I forked your project, branched off @carlos-stored master, rebased to your master and updated index.jsx. Is that okay protocol for me to open a PR or are there other steps I should take? Thanks for the great project!

KyleAMathews commented 7 years ago

@kkozee yeah, that'd be great! Just push your changes to Github and create the PR!

KyleAMathews commented 7 years ago

Fixed in https://github.com/KyleAMathews/react-spinkit/pull/49