search

KyleAMathews / react-spinkit

A collection of loading indicators animated with CSS for React
http://kyleamathews.github.io/react-spinkit/
MIT License
1.49k stars 73 forks source link

Coloring the spinners #37

Closed canibanoglu closed 7 years ago

canibanoglu commented 7 years ago

Hello,

I've seen that this has been proposed before and you said there that you would accept a pull request implementing this. I just wanted to make sure that you are still open to the idea before I actually implement this.

Kind regards,

Can

canibanoglu commented 7 years ago

Actually not only coloring but I think passing down styles would be hugely beneficial. Currently the only way to style the spinner is through CSS and that actually binds my CSS declarations to the HTML generated which is far from ideal under React, imo.

canibanoglu commented 7 years ago

Morever, I think there should be support for adding multiple class to the container div. Currently there is a way around that by separating multiple class names in the overrideSpinnerClassName prop, but that is a bit clumsy I think.

lematt1991 commented 7 years ago

Any progress on this?

KyleAMathews commented 7 years ago

Open to a PR.

merrywhether commented 7 years ago

Fixed in 3.0