search

KyleAMathews / react-spinkit

A collection of loading indicators animated with CSS for React
http://kyleamathews.github.io/react-spinkit/
MIT License
1.49k stars 73 forks source link

Coffeescript -> ES6 #38

Closed leahjlou closed 8 years ago

leahjlou commented 8 years ago
KyleAMathews commented 8 years ago

Oh nice! This is looking great.

I normally use the src for example pages as the src will be built by whatever is building the example page. This way you can iterate on both the src and examples w/o needing extra watchers/builders e.g. what I did for react-gravatar https://github.com/KyleAMathews/react-gravatar/blob/master/www/pages/index.js

Actually on that subject — this doesn't need to be part of this PR but it would be nice to convert the examples page to use Gatsby as has everything needed for docs page built in (hot dev, build step, deploy script for github pages, etc.)

Have you setup eslint before? It'd be nice to get that in as well. I normally use Airbnb's config.

Lastly I tried running this and it looks like babel-cli didn't make it into the devDependencies.

Thanks for making this happen!

leahjlou commented 8 years ago

@KyleAMathews Great points -- I probably won't be adding Gatsby in this pr but I think adding eslint would help a lot w/ polish. I'll have an update soon!

KyleAMathews commented 8 years ago

Published 1.1.9!!! Thanks again! Awesome work. Also we have a shiny-ier new site courtesy of Gatsby http://kyleamathews.github.io/react-spinkit/

One other quick change I made before publishing you might be interested in — I removed the peerDependencies. It's kind of a crappy API. NPM 2 treats them very differently than NPM 3 and they tend to be far more confusing than helpful. The only time I'd say for sure use peerDependencies is if your component depends on a specific version of say React e.g. it doesn't work before React 0.14. Then peerDependencies are helpful as they ensure a version dependency. But since react-spinkit works for almost any version of React, peerDependencies aren't helpful.