search

KyleAMathews / react-spinkit

A collection of loading indicators animated with CSS for React
http://kyleamathews.github.io/react-spinkit/
MIT License
1.49k stars 73 forks source link

Depends on JQuery!? #60

Open bradennapier opened 7 years ago

bradennapier commented 7 years ago

spinners.css claims to be not dependent on JQuery but it is breaking my app because I do not have $ in my global...

$.fn.loaders = function() {
    return this.each(function() {
      var elem = $(this);
      $.each(divs, function(key, value) {
        if (elem.hasClass(key))
          elem.html(addDivs(value))
      })
    });
  };

it tries to load that and fails

Would also be nice to not depend on not using css modules without a hack. Perhaps just having one include the css manually like most other modules work?

lucianoratamero commented 7 years ago

+1

qjflores commented 7 years ago

https://stackoverflow.com/questions/37496732/webpack-froala-cannot-read-property-fn-of-undefined-1312

NYCJacob commented 7 years ago

+1 I am doing a simple React app with no jquery no bootstrap and it breaks my app. Uncaught TypeError: Cannot read property 'fn' of undefined at loaders.css.js:43 at Object. (loaders.css.js:59) at webpack_require (bootstrap 3b62f8c…:555) at fn (bootstrap 3b62f8c…:86) at Object. (index.js:40) at webpack_require (bootstrap 3b62f8c…:555) at fn (bootstrap 3b62f8c…:86) at Object. (Search.js:6) at __webpack_require__ (bootstrap 3b62f8c…:555) at fn (bootstrap 3b62f8c…:86)

taschetto commented 6 years ago

+1... this should not be here :(

iBasit commented 6 years ago

+1