KyleAMathews / superagent-bluebird-promise

Add promise support to superagent using Bluebird
MIT License
182 stars 37 forks source link

Option to pass existing superagent instance to be patched #57

Open jpodwys opened 8 years ago

jpodwys commented 8 years ago

I'm the creator of superagent-cache and someone recently reported an issue to me saying that my 1.5.0 release breaks compatibility with this repo. I've created a branch to address the issue and asked the reporter to confirm it meets their needs.

However, I noticed that this repo does not allow a superagent instance to be passed into it. It appears that superagent-promise, superagent-promise-plugin, and my library all allow users to provide an existing superagent instance to be patched. With that in mind, are you open to optionally allowing users to pass in a superagent instance so that, for example, users can patch with my library and then patch with this library to get the bennefits of both?

As I said earlier, I have a branch I believe fixes the issue, but it's not a good fix--I believe this would be better.

Thanks!