search

KyleAMathews / typefaces

NPM packages for Open Source typefaces
2.6k stars 92 forks source link

Recent releases missing `files/` folder in npm package #208

Open jacobq opened 4 years ago

jacobq commented 4 years ago

Recently I updated my typeface-league-spartan package from v0.0.44 to v1.1.13 and found that this broke my application (font no longer loaded). A quick peek at the package tarballs from npm shows that 1.1.8 thru latest (1.1.13) do not contain the files/ folder, which is where the actual font assets are. I have no idea why this font wasn't part of the many other versions between here, and I suppose I shouldn't expect a v0.x package not to break when updating across a 3 years span, but still....

jacobq commented 4 years ago

Repro:

  1. Fetch https://registry.npmjs.org/typeface-league-spartan/-/typeface-league-spartan-0.0.44.tgz
  2. Observe presence of files/ folder in archive: 
    $ tar ztf typeface-league-spartan-0.0.44.tgz
package/package.json
package/.npmignore
package/README.md
package/SIL Open Font License.txt
package/files/.npmignore
package/files/league-spartan-700.eot
package/files/league-spartan-700.svg
package/files/league-spartan-700.ttf
package/files/league-spartan-700.woff
package/files/league-spartan-700.woff2
package/files-hash.json
package/index.css
  3. Fetch https://registry.npmjs.org/typeface-league-spartan/-/typeface-league-spartan-1.1.13.tgz
  4. Observe that the files/ folder is missing: 
    $ tar ztf typeface-league-spartan-1.1.13.tgz
package/index.css
package/files-hash.json
package/package.json
package/README.md
package/SIL Open Font License.txt
jacobq commented 4 years ago

Also, same thing for typeface-cooper-hewitt -- does it have something to do with these fonts not being part of Google Fonts?