search

KyleAMathews / typography.js

A powerful toolkit for building websites with beautiful design
http://kyleamathews.github.io/typography.js/
MIT License
3.84k stars 182 forks source link

Submitting new theme #166

Open Leschonander opened 6 years ago

Leschonander commented 6 years ago

I am submitting a new theme for Typography.js and successfully created a branch on my local computer but I got this error for probably understandable reasons. Authentication failed. You may not have permission to access the repository or the repository may have been archived.

The link to my theme is here https://github.com/Leschonander/typography-theme-zanj . I also have some simple questions on how to get the installation like other themes to work, because the docs for that are unclear. Thanks for any help, this is my first actual open source contribution.

mischah commented 6 years ago

Hej @Leschonander, I guess you have tried to push to this repository. That’s not possible. If it would work that way every stranger could push anything to this.

If you would like to contribute you need to fork this repository to https://github.com/Leschonander/typography.js with that tiny »fork« on the upper right corner of this page.

Then you have to clone your fork on your machine and better work in a feature branch locally. After finishing your changes you have to push your changes to your fork.

Then you finally can create a pull request to ask the owner of this repo to review your changes. He lastly can decide whether he accepts your changes.

You find beginner friendly and way more detailed information about how to contribute to open source software on thus guide: https://opensource.guide/how-to-contribute/#how-to-submit-a-contribution

You will make it :octocat:

Cheers, Michael

Leschonander commented 6 years ago

Thanks for the motivation. I set up the fork on my computer earlier but I keep getting this

unable to access 'https://github.com/KyleAMathews/typography.js.git/': The requested URL returned error: 403

I am not sure what is the issue. I updated Git to the latest version because apparently there was a issue with windows and git recently. I also updated my ssh keys, so I am even more confused. I been also pretty sure doing the correct command for pushing to create a pull request, but why do I have a feeling it's not quite the right one?

git push -u origin New-Typography-Theme-Zanj

Thanks for all the patience,

Best, Lars