search

KyleAMathews / typography.js

A powerful toolkit for building websites with beautiful design
http://kyleamathews.github.io/typography.js/
MIT License
3.84k stars 182 forks source link

Remove -webkit-text-decoration-skip from normalize.css #193

Closed chasemccoy closed 5 years ago

chasemccoy commented 5 years ago

The normalize.css in this file is very outdated, and sets the -webkit-text-decoration-skip property to objects, which causes underlines to overlay descenders on Safari on macOS and iOS. Normalize has since removed this property.

Whenever I use typography.js I always have to remember to fix this by setting -webkit-text-decoration-skip to unset manually. We should remove it here so that users don't have to apply a fix manually.

Ideally, the entire file would be replaced with the latest version of normalize.

rdela commented 5 years ago

Would it make more sense to update normalize to v8.0.1 instead of just removing that one property? Maybe there would be other benefits to upgrading?

chasemccoy commented 5 years ago

It probably would, but it was such a big version jump I avoided it in this PR. Happy to open another if that's the route we want to go, but I am not sure what other effects that change would have.

KyleAMathews commented 5 years ago

The plan is to update to the latest normalize whenever I get around to finishing v1 https://github.com/KyleAMathews/typography.js/issues/158

This seems like a good change in the meantime.