KyleAMathews / typography.js

A powerful toolkit for building websites with beautiful design
http://kyleamathews.github.io/typography.js/
MIT License
3.83k stars 181 forks source link

211 support font display for googlefonts #212

Open dakebl opened 5 years ago

dakebl commented 5 years ago

This PR adds a fontDisplay option to the options object that can be used to add font-display to google fonts imports.

Resolves #211

codecov-io commented 5 years ago

Codecov Report

Merging #212 into master will increase coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
+ Coverage   98.26%   98.29%   +0.03%     
==========================================
  Files          43       43              
  Lines         230      235       +5     
  Branches       17       18       +1     
==========================================
+ Hits          226      231       +5     
  Misses          4        4
Impacted Files Coverage Δ
packages/react-typography/src/GoogleFont.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 18e3d57...84d5eaf. Read the comment docs.

i8ramin commented 3 years ago

Hi. Any chance this will get merged in?