KyleAMathews / typography.js

A powerful toolkit for building websites with beautiful design
http://kyleamathews.github.io/typography.js/
MIT License
3.83k stars 181 forks source link

either overriding styles is unintuitive and under-documented or I need help #251

Open Strangehill opened 4 years ago

Strangehill commented 4 years ago

Making adjustments to the gatsby-blog-starter, I decided that some of the style overrides in the starter, that were made at the component level, would perhaps be better applied globally.

I have mixed success moving these styles from the layout and blog-post template files, to src/utils/typography.js.

When I added these override styles (similar styles) for an h1 and an h3 in separate selectors, there was no result. see images. Screenshot 2020-03-26 16 54 36 Screenshot 2020-03-26 16 54 44 Screenshot 2020-03-26 16 54 59

However, when applying the same rules through a h1,h3 selector these rules are applied. Though the rules for each element are not identical, they overlap so it's a step closer to an acceptable compromise. Screenshot 2020-03-26 16 58 39

Either I'm missing something obvious, or this is a bug, or this is a quirk to using overrideThemeStyles and Typography.js that deserves documentation in the README or elsewhere.