KyleDSwarner / puzzles-reloaded

MIT License
5 stars 0 forks source link

Dead zone at the bottom of the game area #5

Open NLZ opened 3 months ago

NLZ commented 3 months ago

There is an area under the puzzles but above the bottom menu bar that cannot be occupied by the puzzles no matter how they are configured.

Would be nice if it could be reclaimed as I like to set my puzzles to use the most screen possible.

Also the small border at the sides and top is also useless waste of space, as all puzzles have a built in border already.

The white background makes it glaringly obvious, I hope you plan to change that to the same gray color as the puzzle backgrounds.

KyleDSwarner commented 3 months ago

Good eye! There is padding built in to the bottom- it’s used for games that have statusbars and/or the new game button. I had to reserve that space because when it appeared it was resizing the available space for the puzzle, causing some visual issues.

My assumption here was that the screen width would usually be the limiting factor of fitting the puzzle on the screen- but granted landscape mode would be problematic.

There’s almost certainly some better ways to handle this that let the space be drawn on especially for games that don’t need the status bar- I’ll look in to it.

KyleDSwarner commented 3 months ago

RE the white background: yeah, probably worth changing. I’ve been playing on dark mode where it isn’t quite as glaring an issue, updating the background for light mode is reasonable.

I want to fully support dark mode colors on the puzzles in the future, but it will be a bit of an undertaking.

KyleDSwarner commented 3 months ago

Hey @NLZ, I've released a testflight version that I hope will help address some of these issues. I'd love your feedback on how the changes feel: https://testflight.apple.com/join/WTgP9Te4

I wasn't able to easily remove all of the bottom space, but in landscape mode I did reduce it a bit. As an alternative, I've added an option to completely disable the statusbar + new game button popups, which gives the space back to the puzzle. Let me know if you like it!