KyleMayes / vulkanalia

Vulkan bindings for Rust.
Apache License 2.0
267 stars 30 forks source link

Recommendation for Chapter 15 (Fixed Functions) #282

Closed j-n-f closed 2 months ago

j-n-f commented 3 months ago

Hi,

Great tutorial series. I've been going through a bit of this each day for the last week or so.

I finished with Chapter 14 last night and came back to Chapter 15 today. It describes adding a bunch of code, but not where it gets added to. Most of the other chapters show this with some context like:

fn some_function_we_wrote_previously() -> Result<()> {
    // ...
    let some_new_var = ();

    Ok(())
}

I think Chapter 15 would benefit from this treatment.

j-n-f commented 3 months ago

Hah,

Just double-checked and I see:

Add this structure to the create_pipeline function right after the vk::PipelineShaderStageCreateInfo structs.

I guess that technically covers it, but it's unlike the convention I've seen in the rest of the book so far.

KyleMayes commented 2 months ago

Thanks for the feedback, I've added more context to the code in this chapter.