fix: allow attributes on paragraphs with tweets

KyleMit / eleventy-plugin-embed-tweet

A plugin for embedding tweets on the server side during build time

https://www.npmjs.com/package/eleventy-plugin-embed-tweet

25 stars 4 forks source link

fix: allow attributes on paragraphs with tweets #22

Closed ovlb closed 1 year ago

ovlb commented 2 years ago

The old reg ex is only capturing <p> elements if those elements have no attribute set (eg class or id). This PR expands the reg ex to allow any attributes to be present.

Demo on regexr: https://regexr.com/6v8ih

ovlb commented 1 year ago

friendly ping :)

KyleMit commented 1 year ago

Thank you so much for the PR and the friendly ping! This definitely fell of my brain TODOs list. Changes look great

KyleMit commented 1 year ago

Shipped in v0.3.3