search

KyleVaughn / UM2

An unstructured mesh library for automated method of characteristic mesh generation
https://univeristy-of-michigan-unstructured-mesh-code.readthedocs.io/en/main/index.html#
MIT License
7 stars 2 forks source link

Overload Material.addNuclide to allow atom fractions and weight fractions #150

Closed KyleVaughn closed 3 months ago

KyleVaughn commented 8 months ago

Currently nuclides are added to a material using the number density, which is not always the easiest to compute.

KyleVaughn commented 3 months ago

A Material.addNuclideWt function, which takes a weight percent has been merged into main. We still need an atom fraction function.

Should we create 3 different functions, or use a single function which maybe takes an enum with {NumberDensity, AtomPercent, WeightPercent}? We should look at other open source codes for inspiration.

KyleVaughn commented 3 months ago

Added in https://github.com/KyleVaughn/UM2/pull/161