search

Kylemc1413 / SongCore

A plugin for handling custom song additions in Beat Saber.
MIT License
86 stars 48 forks source link

Fix/restore environment color override behavior #113

Closed aszorenyi closed 1 year ago

aszorenyi commented 1 year ago

At previous versions environment/light colors inherited note colors if the map didn't set it. This was changed with commit d92ec06. With the current version it inherits the default colors if neither the map sets it explicitly, nor the user overrides it with custom colors.

I don't know if the change was intentional or not, this commit simply restores the previous behavior (fixes issue #111 created by me).

ErisApps commented 1 year ago

@XAce1337manX Mind taking a second look at this?

XAce1337manX commented 1 year ago

Change was intentional however didn't realise editors relied on fallback behaviour instead of setting colours explicitly if they used the same colour. Restoring behaviour looks good.