search

Kylemc1413 / SongCore

A plugin for handling custom song additions in Beat Saber.
MIT License
86 stars 48 forks source link

Fixes for Beat Saber v1.31.0 #120

Closed Meivyn closed 1 year ago

Meivyn commented 1 year ago

This contains a couple of optimizations on the side, I tested most of it, but would appreciate it if others could test it to make sure I didn't forget anything.

I modified the beatmap version detection patch for consistency with base game. I don't know which is faster, both are working. But base game is still missing the fallback which is needed for about ~ 3.20% of maps.

ErisApps commented 1 year ago

I'm currently not sure whether the new basegame implementation is faster than the RegEx we had up until now so will try to validate that throughout the weekend.

ErisApps commented 1 year ago

@Meivyn Did some testing throughout the weekend and saw that on average, the RegEx-based version detection approach seemed to be roughly ~100x faster than the JSON-based approach. So I would like to advice to revert that patch back to the original one. 🙂

Meivyn commented 1 year ago

image

This is also my conclusion.