search

Kylemc1413 / SongCore

A plugin for handling custom song additions in Beat Saber.
MIT License
86 stars 48 forks source link

Boost colour lights are removed when disabling custom song colour scheme #146

Closed qqrz997 closed 5 months ago

qqrz997 commented 5 months ago

if you disable a map's own colour scheme, you are not using your own colour overrides, and the map uses boost colours, then any boost colour lights don't show up - probably because they're using a completely transparent colour.

in the base game if you use boost colours on a colour scheme that doesn't have boost colours set it will default to the non-boost colours, so the lights aren't invisible.

if this is intentional let me know.

qqrz997 commented 5 months ago

title might be a bit misleading but i tried to word this as best i could

Meivyn commented 5 months ago

Can you provide a link to a map on which you noticed this issue? I cannot reproduce it.

qqrz997 commented 5 months ago

donut hole is the map i noticed it on, boost is used during the chorus around the minute mark

Meivyn commented 5 months ago

Can you show me a video of what you mean? I still cannot reproduce with this map. Lights should be off? Are you on latest?

qqrz997 commented 5 months ago

yes this is with songcore from beatmods on 1.36.2

with songcore the lights go invisible

in vanilla they use the primary colours when there aren't any in use - panic environment uses "the first" colour scheme

Meivyn commented 5 months ago

Okay, I was able to reproduce, thanks for showing. It happens when you disable the environment colors but keep note colors or obstacle colors on. In this case, the map has none so it's just invisible. I'll look at it.