search

Kylemc1413 / SongCore

A plugin for handling custom song additions in Beat Saber.
MIT License
87 stars 48 forks source link

Patch out legacy BPM events support #149

Closed NSGolova closed 3 months ago

NSGolova commented 3 months ago

Event with a type 10 was introduced as an official BPM change event in 1.8.0 and later reused as a light in 1.18.0. This change disables the conversion of legacy BPM changes to add support for maps with type 10 events as lights, but with a wrong map version.

From the collection of 170k recently (last 2 years) played maps, there were 226 broken maps because of the conversion. Some are quite popular, and 2 ranked maps (1 on BL and 1 on SS). And not a single map that properly utilized these events as BPM changes. Popular mapping tools (MM/custom saber/CM) never had support for this event, and mappers who tried to use them manually were complaining, so I couldn't even find an example map, let alone a map anyone plays.

NSGolova commented 3 months ago

List of the maps with version <2.5.0 that use event 10 as lights event10_pre25_lights.txt