Kyligence / ClickHouse

ClickHouse® is a free analytics DBMS for big data
https://clickhouse.com
Apache License 2.0
14 stars 17 forks source link

[GLUTEN-2463][CH] Allow nullable tuple column as input in Nested::flatten #453

Closed taiyang-li closed 1 year ago

taiyang-li commented 1 year ago

Changelog category (leave one):

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

close issues: https://github.com/oap-project/gluten/issues/2463 and https://github.com/oap-project/gluten/issues/2459

kyligence-git commented 1 year ago

Can one of the admins verify this patch?

lgbo-ustc commented 1 year ago

It looks like BlockUtil::flattenBlock becomes the same as NestedUtil::flatten. May replace BlockUtil::flattenBlock. BlockUtil::flattenBlock was added mainly for the nullability. And it's used in the local parquet/orc format, I think it may work fine in the local parquet/orc format at present.

taiyang-li commented 1 year ago
$ ./build_gcc/utils/extern-local-engine/tests/unit_tests_local_engine  --gtest_filter="NestedUtils.*" --gtest_catch_exceptions=0         2>&1 | tee run.log      
2023-07-26 15:15:54.787 <Warning> SignalHandler: LD_PRELOAD is not set, SignalHandler is disabled
Note: Google Test filter = NestedUtils.*
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from NestedUtils
[ RUN      ] NestedUtils.flatten
[       OK ] NestedUtils.flatten (0 ms)
[----------] 1 test from NestedUtils (0 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (0 ms total)
[  PASSED  ] 1 test.
lgbo-ustc commented 1 year ago

LGTM