Closed taiyang-li closed 1 year ago
Can one of the admins verify this patch?
It looks like BlockUtil::flattenBlock
becomes the same as NestedUtil::flatten
. May replace BlockUtil::flattenBlock
. BlockUtil::flattenBlock
was added mainly for the nullability. And it's used in the local parquet/orc format, I think it may work fine in the local parquet/orc format at present.
$ ./build_gcc/utils/extern-local-engine/tests/unit_tests_local_engine --gtest_filter="NestedUtils.*" --gtest_catch_exceptions=0 2>&1 | tee run.log
2023-07-26 15:15:54.787 <Warning> SignalHandler: LD_PRELOAD is not set, SignalHandler is disabled
Note: Google Test filter = NestedUtils.*
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from NestedUtils
[ RUN ] NestedUtils.flatten
[ OK ] NestedUtils.flatten (0 ms)
[----------] 1 test from NestedUtils (0 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (0 ms total)
[ PASSED ] 1 test.
LGTM
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
close issues: https://github.com/oap-project/gluten/issues/2463 and https://github.com/oap-project/gluten/issues/2459