Kyligence / ClickHouse

ClickHouse® is a free analytics DBMS for big data
https://clickhouse.com
Apache License 2.0
14 stars 17 forks source link

[GLUTEN-2582][CH]Bug fix crash in array struct select #456

Closed KevinyhZou closed 1 year ago

KevinyhZou commented 1 year ago

Changelog category (leave one):

Bug fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Bug fix problem described in: https://github.com/oap-project/gluten/issues/2582

While use array as filter, like select * from table where data[0].a = 1, it will use arrayElement function to do its filter action, and go to #perform#executeTuple at arrayElement.cpp, which will return directly, and not init sink to builder.

and the sink_null_map_holder in builder not init, still is a nullptr, the left procedure will transform on this nullptr, and cause crash.

Documentation entry for user-facing changes

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

kyligence-git commented 1 year ago

Can one of the admins verify this patch?