search

KyoheiG3 / SimpleAlert

Customizable simple Alert and simple ActionSheet for Swift
MIT License
398 stars 45 forks source link

can't modify message text #14

Closed grantism closed 6 years ago

grantism commented 8 years ago

After initializing a simpleAlert controller, it is possible to change the title, but it is not possible to change the message.

This works: let alert = SimpleAlert.Controller(title: "blah", message: "blah", style: .Alert) alert.title = "changed it"

But this doesn't: let alert = SimpleAlert.Controller(title: "blah", message: "blah", style: .Alert) alert.message = "changed it"

For consistency & flexibility, it should be possible to set the message value in the same way as the title.

KyoheiG3 commented 8 years ago

Oh, Sorry, It is a bug that title can be changed. Do you need the property to change message? Thanks.

grantism commented 8 years ago

That makes sense. I was coming from the point of view of the standard UIAlertController & other UI items which allows changing the title and message properties after initialisation (More as a point of keeping consistency with other UI elements than anything else).

I suppose this issue should be 'Don't allow modification of title after initialisation' instead :)

KyoheiG3 commented 6 years ago

Message text became to be able to modify in #32.