search

Kyon147 / laravel-shopify

A full-featured Laravel package for aiding in Shopify App development
MIT License
353 stars 102 forks source link

Moved the API namespace from osiset to gnikyt #168

Closed SachinBahukhandi closed 1 year ago

SachinBahukhandi commented 1 year ago

This is a fix with reference to the issue: #166

SachinBahukhandi commented 1 year ago

@Kyon147 I fixed the linting and ran tests. Could you please review?

SachinBahukhandi commented 1 year ago

This looks good.

TODO: add the upgrade instructions to the wiki as you wiki need to edit the config files too if you already have an installed app.

Shall that go on this PR or as a separate one?

SachinBahukhandi commented 1 year ago

@Kyon147 Ok I just came to know that we can update wiki directly, thus if it appears to be fine. Kindly merge the PR. Much thanks!

Kyon147 commented 1 year ago

@SachinBahukhandi yeah sorry that Todo was more for me to remember!

SachinBahukhandi commented 1 year ago

@SachinBahukhandi yeah sorry that Todo was more for me to remember!

No problem.