search

Kyon147 / laravel-shopify

A full-featured Laravel package for aiding in Shopify App development
MIT License
336 stars 99 forks source link

Host param is being unset on SPA #200

Closed ncpope closed 10 months ago

ncpope commented 11 months ago

Expected Behavior

I am seeing the host param removed when using React and verify.shopify middleware on web.php routes. This is required to get app bridge 3.1 working correctly.

Current Behavior

When I do a dump of the request I see all of the original request parameters. However, after doing a dump after a new shop is authenticate the host param is being unset.

Failure Information

Screenshot 2023-08-19 at 12 55 35 Screenshot 2023-08-19 at 12 57 50 Screenshot 2023-08-19 at 12 58 14

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. Use middleware ('verify.shopify');

Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

ncpope commented 11 months ago

201 This was tested on a production app and it has resolved the issue. Previously, new merchants were unable to install the app.

Kyon147 commented 11 months ago

@ncpope I can see you closed the pull request - what was the reason?

I use SPA on my apps, and have no run into any issues - so would be good to know if there is still a bug somewhere.

ncpope commented 10 months ago

@Kyon147 I made further changes to the branch on my repo not knowing that it would automatically update the pull request here.

The additional fixes were going to be just specific to my apps needs and were not meant to update the pull request. I will create a new pull request after I undo the changes.

Can I ask what your setting value is for SHOPIFY_FRONTEND_ENGINE?

Kyon147 commented 10 months ago

I use REACT but use Vue as the FE as I think we never actually implemented VUE as a value but it is meant to do the same thing. I'll need to check to see if it was every updated.