search

Kyon147 / laravel-shopify

A full-featured Laravel package for aiding in Shopify App development
MIT License
336 stars 99 forks source link

Adding Support for AWS EventBridge for Shopify Webhooks #224

Open usmanpakistan opened 9 months ago

usmanpakistan commented 8 months ago

Hello @Kyon147 , I hope everything is going well. It's been a while since this PR was submitted, what are your thoughts on it? Is there anything else that needs to be changed or improved?

Kyon147 commented 8 months ago

Hey @usmanpakistan

Could you update me on what the PR is for, what it looks to solve and how someone would set it up?

Also, some of the tests are failing, could you take a look.

usmanpakistan commented 8 months ago

@Kyon147 This PR resolve issue reported previously on the legacy laravel-shopify package. It enables a user to provide an EventBridge ARN while subscribing to Webhooks. You can refer to your comment here for more detail https://github.com/gnikyt/laravel-shopify/issues/1113#issuecomment-1086071686

usmanpakistan commented 5 months ago

@Kyon147 Any update on this PR

Jamesking56 commented 4 months ago

@Kyon147 Any update on this PR

Your PR is still failing tests, resolve those first please

Kyon147 commented 4 months ago

Hey @usmanpakistan

As @Jamesking56 mentions please fix the failing tests and I can re-review once they are good.

usmanpakistan commented 3 months ago

@Jamesking56 @Kyon147 can I get some help with fixing these tests. I am not well versed with writing them. I have tried a lot to fix the tests but these are still failing