search

Kyon147 / laravel-shopify

A full-featured Laravel package for aiding in Shopify App development
MIT License
336 stars 99 forks source link

Update AppUninstalledJob.php #229

Open andreybutov opened 8 months ago

andreybutov commented 8 months ago

null guard against an invalid shop on uninstall

We had a situation in dev where Shopify sent a bunch of uninstall webhook requests in bursts. This resulted in a state where the $shop returned from getByDomain(...) was null, resulting in an error being thrown. This is a simple guard against that null. I'm not super familiar with the package, so if there's cleanup to be done before returning, or if there's a better way to handle this, by all means.

Kyon147 commented 8 months ago

Thanks for the PR - i'll take a look this week.

Kyon147 commented 7 months ago

@andreybutov there are some failing checks - can you take a look?