search

KyoriPowered / adventure

A user-interface library, formerly known as text, for Minecraft: Java Edition
https://docs.advntr.dev/
MIT License
679 stars 105 forks source link

revise: MiniMessageTranslator #972 #1089

Closed KKW557 closed 3 days ago

KKW557 commented 3 days ago

This PR is based on the original PR #972 . The original PR was not merged due to several review comments, and the original author is no longer making updates. To continue the development and integration of this feature, I have revised and improved the initial submission.

KKW557 commented 3 days ago

I don't really see a point in this? Besides the fact that the other PR is still marked as a draft, Kezz should be marked as the main author and you as a co author at least.

His activities have been gone for three months, and I'm not the author or co author, I think the feature is good but it hasn't been changed in a long time

masmc05 commented 3 days ago

There should be a reason why he didn't finish or why he didn't mark the pr as ready, and the author is active, just not on that pr.

Be patient

kezz commented 3 days ago

The original PR is waiting on virtual components for named arguments (i.e. <name> instead of <arg:1>).