search

KyoriPowered / adventure

A user-interface library, formerly known as text, for Minecraft: Java Edition
https://docs.advntr.dev/
MIT License
679 stars 105 forks source link

feat(api): introduce ResourcePackRequest #981

Closed yusshu closed 7 months ago

Machine-Maker commented 9 months ago

Is ResourcePack a good name? I feel like you aren't really dealing with a resourcepack, like the object that might exist on the client, but rather ResourcePackInfo or something like that.

yusshu commented 9 months ago

Is ResourcePack a good name? I feel like you aren't really dealing with a resourcepack, like the object that might exist on the client, but rather ResourcePackInfo or something like that.

I'm not sure what its name should be, but I agree that it feels like we are not working with an actual resource pack. I call this class "ResourcePackRequest" in my plugin

zml2008 commented 9 months ago

Please remember to resolve the codestyle issues in this PR (first run ./gradlew spotlessApply, then ./gradlew check and fix any issues that remain)