Kyoso-Team / kyoso

A web application that takes osu! tournaments beyonds spreadsheets.
http://kyoso.sh
GNU Affero General Public License v3.0
1 stars 1 forks source link

Migration to Skeleton v2 #14

Closed Entropy-10 closed 9 months ago

Entropy-10 commented 10 months ago

Using the provided migration docs from Skeleton I migrated the project from v1 to v2. I also updated all the dependencies in the project using pnpm up. None of these upgrades introduced breaking changes (tested pre-migration to Skeleton v2). Currently there is a weird bug with starting the dev server. I described the issue on discord, but I will restate here so others can have a crack at fixing it. This issue was also tested without updating the other project dependencies and still occurs.

There is currently a weird issue where if you try to start it the site normally it loads forever. Though if I add back this import (which the v2 guides say to remove): import '@skeletonlabs/skeleton/styles/all.css' it will load then crash (which is expected), but if I comment it out without restarting the dev server everything works fine. Though if I remove the import and try restarting the dev server it gets stuck loading forever. I've tested this multiple times it 100% of the time has the same behavior and I'm not sure how to fix it.

https://github.com/Kyoso-Team/kyoso/assets/45132530/cc682147-5543-46a2-b3e9-dcf37e3f0535

update: the black magic was real with this one

Entropy-10 commented 10 months ago

h1 and h2 tags have a normal text size instead of each's respective larger ones. Everything else seems fine though.

Got it, I will take a peak to see what's going on with that.