Kyrluckechuck / TFT-Bot

Automate Teamfight Tactics (TFT) for token/mission farming. Updated for Set 8.5!
GNU Affero General Public License v3.0
50 stars 7 forks source link

Lint all the things #103

Closed akshualy closed 1 year ago

akshualy commented 1 year ago

Consider the following linting tools:

  1. isort - Enforced, Configured
  2. black - Not enforced and not configured
  3. flake8 - Not enforced, but configured
  4. pylint - Not enforced, but configured

isort

isort is fine as it is and should stay as it is.

black

The only thing this tool needs as the configuration is line-length. I usually go between 80 to 100 (to support quick terminal editing in vim/nano), but I would be OK with up to 120. Everything above seems a bit excessive.

flake8

pylint

I have never used this, only used mypy before, so your feedback on this is more valuable than mine :) But at a glance, this also needs to be adjusted for line length.

Enforcement

We should consider adding pre-commit to help with committing clean code and adding a pipeline step to check each of the linting tools.