search

Kyrluckechuck / TFT-Bot

Automate Teamfight Tactics (TFT) for token/mission farming. Updated for Set 8.5!
GNU Affero General Public License v3.0
50 stars 7 forks source link

Overhaul Release Workflow #121

Closed Kyrluckechuck closed 1 year ago

Kyrluckechuck commented 1 year ago

Description

Overhauls the release workflow to be less every-main-branch-merge and instead be kicked off by manual workflow triggers on the main branch.

I initially went the poetry approach, however, after digging further and actually getting it set up, I decided that poetry introduces way too much overhead and is prone to dependency resolution issues (specifically shared dependencies of dependencies), among some other issues (such as higher overhead for CI workflows and "incompatibility" with native Python workflows (such as having to pre-install or post-install poetry for each usage).

This isn't the cleanest solution, since it requires a PR to bump the version each time, but I decided that was "good enough" for now and am open to suggestions / PRs in the future.

Fixes https://github.com/Kyrluckechuck/TFT-Bot/issues/116

akshualy commented 1 year ago

✨ 10/10 commit messages ✨ . I'm sad we couldn't use poetry, but I understand the reasoning.